Skip to content

Generate parameters from yaml#11

Open
tylerjw wants to merge 1 commit intoPickNikRobotics:ros2from
tylerjw:generate_parameters
Open

Generate parameters from yaml#11
tylerjw wants to merge 1 commit intoPickNikRobotics:ros2from
tylerjw:generate_parameters

Conversation

@tylerjw
Copy link
Copy Markdown

@tylerjw tylerjw commented Aug 2, 2022

Signed-off-by: Tyler Weaver tyler@picknik.ai

Here is a minimal conversion to using generate_parameter_library for parameters. I didn't use any of the functionality for validation but this can easily be added.

Signed-off-by: Tyler Weaver <tyler@picknik.ai>
@wyattrees
Copy link
Copy Markdown

wyattrees commented Aug 11, 2022

Is there a way to add a generic namespace here that can be determined at runtime? The parameters for IK plugins actually come in the form robot_description_kinematics.<group_name>.<param_name> (i.e. for the panda arm, the solver mode is robot_description_kinematics.panda_arm.mode). None of the parameters here are actually being retrieved from kinematics.yaml.

btw, sorry for the delay on this--been pulled into a lot of debugging recently.

@tylerjw
Copy link
Copy Markdown
Author

tylerjw commented Aug 12, 2022

I think that is a misuse of namespaces and a poorly designed interface. Is there a reason you might have multiples of bio_ik in the same ros node that need to have separate namespaces for the parameters?

Remember that in ROS 2 parameters are per-node and not part of some global parameter server.

@wyattrees
Copy link
Copy Markdown

wyattrees commented Aug 12, 2022

We'd need to make that change in MoveIt then, as it reads kinematics.yaml and sets those parameters. Or, you could potentially get rid of the group name in the yaml file and the parameters would just be robot_description_kinematics.param_name

The only possible use case I can think of is computing IK for multiple arms simultaneously, but if they're a part of the same group then you'd only need one bio_ik instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants